[PATCH v4 4/5] dump/restore: Use Xapian queries for batch-tag format

David Bremner david at tethera.net
Mon Dec 31 08:52:27 PST 2012


Mark Walters <markwalters1009 at gmail.com> writes:

> One other thing that is noticeable from the errors is that most of the
> rest of the errors are very informative but the parse_boolean_term one
> is relatively uninformative: it just says we cannot parse the id even
> though we know rather more about what the error is (trailing text, no
> closing quote, illegal character in an unquoted id etc). I am happy with
> it how it is but perhaps David Bremner might like to comment?

I don't see a simple way to report better errors without adding more
status values to parse_boolean_term; in the other cases we report the
error as it is detected, in the cli code. I also don't think it's
correct for routines in ./util to directly print error messages.

d


More information about the notmuch mailing list