[Patch v2 1/4] CLI: add talloc leak report, controlled by an environment variable.
david at tethera.net
david at tethera.net
Wed Dec 26 13:58:28 PST 2012
From: David Bremner <bremner at debian.org>
The argument handling in notmuch.c seems due for an overhaul, but
until then use an environment variable to specify a location to write
the talloc leak report to. This is only enabled for the (interesting)
case where some notmuch subcommand is invoked.
---
notmuch.c | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/notmuch.c b/notmuch.c
index ee2892e..6b7aae8 100644
--- a/notmuch.c
+++ b/notmuch.c
@@ -321,8 +321,28 @@ main (int argc, char *argv[])
for (i = 0; i < ARRAY_SIZE (commands); i++) {
command = &commands[i];
- if (strcmp (argv[1], command->name) == 0)
- return (command->function)(local, argc - 1, &argv[1]);
+ if (strcmp (argv[1], command->name) == 0) {
+ int ret;
+ char *talloc_report;
+
+ ret = (command->function)(local, argc - 1, &argv[1]);
+
+ /* in the future support for this environment variable may
+ * be supplemented or replaced by command line arguments
+ * --leak-report and/or --leak-report-full */
+
+ talloc_report = getenv ("NOTMUCH_TALLOC_REPORT");
+
+ /* this relies on the previous call to
+ * talloc_enable_null_tracking */
+
+ if (talloc_report && strcmp (talloc_report, "") != 0) {
+ FILE *report = fopen (talloc_report, "w");
+ talloc_report_full (NULL, report);
+ }
+
+ return ret;
+ }
}
fprintf (stderr, "Error: Unknown command '%s' (see \"notmuch help\")\n",
--
1.7.10.4
More information about the notmuch
mailing list