[PATCH 1/3] CLI: add talloc leak report, controlled by an environment variable.

[Tomi Ollila]

On Mon, Dec 17 2012, david at tethera.net wrote:

> From: David Bremner <bremner at debian.org>
>
> The argument handling in notmuch.c seems due for an overhaul, but
> until then use an environment variable to specify a location to write
> the talloc leak report to.  This is only enabled for the (interesting)
> case where some notmuch subcommand is invoked.
> ---

I'd still suggest to have similar command-line interface option(s) as
samba4 use: --leak-report and/or --leak-report-full

(search --leak-r in talloc(3) namual page)

Tomi

>  notmuch.c |   16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/notmuch.c b/notmuch.c
> index 9516dfb..fb49c5a 100644
> --- a/notmuch.c
> +++ b/notmuch.c
> @@ -322,8 +322,20 @@ main (int argc, char *argv[])
>      for (i = 0; i < ARRAY_SIZE (commands); i++) {
>  	command = &commands[i];
>  
> -	if (strcmp (argv[1], command->name) == 0)
> -	    return (command->function) (local, argc - 1, &argv[1]);
> +	if (strcmp (argv[1], command->name) == 0) {
> +	    int ret;
> +	    char *talloc_report;
> +
> +	    ret = (command->function) (local, argc - 1, &argv[1]);
> +
> +	    talloc_report=getenv ("NOTMUCH_TALLOC_REPORT");
> +	    if (talloc_report && strcmp(talloc_report, "") != 0) {
> +		FILE *report = fopen (talloc_report, "w");
> +		talloc_report_full (NULL, report);
> +	    }
> +
> +	    return ret;
> +	}
>      }
>  
>      fprintf (stderr, "Error: Unknown command '%s' (see \"notmuch help\")\n",
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch