[Patch v7 06/14] notmuch-restore: move query handling for batch restore to parser

David Bremner david at tethera.net
Sat Dec 15 10:18:23 PST 2012


Mark Walters <markwalters1009 at gmail.com> writes:

>> +	if (hex_decode_inplace (tok) != HEX_SUCCESS) {
>> +	    ret = line_error (TAG_PARSE_INVALID, line_for_error,
>> +			      "hex decoding of query %s failed", tok);
>> +	    goto DONE;
>> +	}
>> +	/* skip 'id:' */
>> +	*query_string = tok + 3;
>
> This looks like it doesn't double_quote the query_string in this (the
> TAG_FLAG_ID_ONLY) case. Is that deliberate?

Yes, that's what I meant by 

,----
| We also need this to avoid the query quoting for more
| general queries (to be written) that will mess up raw message-ids.
`----

perhaps it deserves a comment in the code.


More information about the notmuch mailing list