[PATCH v4 3/5] Use the S-Expression structured printer in notmuch-show, notmuch-reply and notmuch-search.

[Jameson Graef Rollins]

On Fri, Dec 07 2012, Mark Walters <markwalters1009 at gmail.com> wrote:
> Jameson Graef Rollins <jrollins at finestructure.net> writes:
>
>> On Thu, Dec 06 2012, Peter Feigl <craven at gmx.net> wrote:
>>> -    /* Any changes to the JSON format should be reflected in the file
>>> -     * devel/schemata. */
>>> +    /* Any changes to the JSON or S-Expression format should be
>>> +     * reflected in the file devel/schemata. */
>>
>> Can we just make these comments more general, so we don't have to tweak
>> them every time a new formatter is added?
>
> I think I agree, but I think it may as well wait until we have more than
> the two formats. In other words I would suggest not holding up the
> (latest version) of this series for this.

Yes, that's totally fair.  I didn't notice later that a new version of
the patch had already been sent.

I haven't had a chance to review the patches, but I am certainly all for
the feature.  Definitely don't hold it up on this account.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121207/77b0a105/attachment.pgp>