[PATCH] emacs: add support for stashing the thread id in show view

[Mark Walters]

On Thu, 06 Dec 2012, Jani Nikula <jani at nikula.org> wrote:
> Add a prefix argument to notmuch-show-stash-message-id to stash thread
> id instead of message id.
> ---
>  emacs/notmuch-show.el |   13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 4d6c014..2245b4f 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1901,10 +1901,15 @@ thread from search."
>    (interactive)
>    (notmuch-common-do-stash (notmuch-show-get-from)))
>  
> -(defun notmuch-show-stash-message-id ()
> -  "Copy id: query matching the current message to kill-ring."
> -  (interactive)
> -  (notmuch-common-do-stash (notmuch-show-get-message-id)))
> +(defun notmuch-show-stash-message-id (&optional thread-id)
> +  "Copy id: query matching the current message to kill-ring.
> +
> +If invoked with a prefix argument (or THREAD-ID is non-nil), copy
> +thread: query matching the current thread to kill-ring."
> +  (interactive "P")
> +  (if thread-id
> +      (notmuch-common-do-stash notmuch-show-thread-id)
> +    (notmuch-common-do-stash (notmuch-show-get-message-id))))
>  

Basically this looks good to me. My one criticism is the name of the
argument: thread-id looks like it should be umm, a thread-id. Maybe
thread-id-wanted or something?

Best wishes

Mark


>  (defun notmuch-show-stash-message-id-stripped ()
>    "Copy message ID of current message (sans `id:' prefix) to kill-ring."
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch