[PATCH] emacs: stash bugfix

Mark Walters markwalters1009 at gmail.com
Sun Dec 2 02:11:08 PST 2012


Currently an attempt to stash a non-existent field (eg cc when not
present) throws an error. Catch this case and give the user a warning
message.

---
While messing around with notmuch-pick key bindings I found the
following bug. The easiest way I have found to trigger it is cc
(stash-cc) in show mode on a message with no cc header.

Best wishes

Mark

 emacs/notmuch-lib.el |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 1d0ec17..c7d8e02 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -183,8 +183,11 @@ user-friendly queries."
 
 (defun notmuch-common-do-stash (text)
   "Common function to stash text in kill ring, and display in minibuffer."
-  (kill-new text)
-  (message "Stashed: %s" text))
+  (if text
+      (progn
+	(kill-new text)
+	(message "Stashed: %s" text))
+    (message "Warning: Nothing to stash!")))
 
 ;;
 
-- 
1.7.9.1



More information about the notmuch mailing list