[PATCH v3 2/2] notmuch-show.el: handle the case where icalendar-import-buffer returns nil

David Bremner david at tethera.net
Wed Nov 21 19:51:28 PST 2012


Tomi Ollila <tomi.ollila at iki.fi> writes:

> icalendar-import-buffer can fail by an error signal (which have been
> witnessed) but according to its docstring it can also return nil
> when failing (it returns t when succeeding).
>
> Now that the error is caught by the caller of notmuch-show-inset-part-*
> functions in case icalendar-import-buffer returns nil an explicit
> error is signaled and unwind-protect takes care of deleting the
> temporary file (just in case, it is usually not written to the fs yet).

This one looks OK to me too, although the API that makes it necessary
out to be taken out back...

d


More information about the notmuch mailing list