[PATCH 01/18] cli: add stub for insert command
Peter Wang
novalazy at gmail.com
Mon Nov 19 04:34:35 PST 2012
On Sun, 18 Nov 2012 17:35:23 +0000, Mark Walters <markwalters1009 at gmail.com> wrote:
>
> Hi
>
> I have now been through essentially the whole series (except the tests)
> and broadly like it. Just to summarise my concerns from the individual
> replies here:
Thanks for the review.
>
> What should insert do when interrupted and is it safe? I am not
> knowledgeable enough to be confident about that.
Do you mean cleaning up stray files? Otherwise I think we just return
an error code, and then it's the caller's responsibility.
>
> I think some of the talloc allocations need their return values
> checked. I am more worried about this here then in most of the rest of
> notmuch as we are writing to the database (and even to the mailstore
> itself).
Will do.
Peter
More information about the notmuch
mailing list