[PATCH v3 00/10] Solaris support

[Tomi Ollila]

On Wed, Nov 14 2012, Blake Jones wrote:

> Updated based on comments from Tomi Ollila last week:
>
> - Cleaned up the $(INSTALL) changes in vim/Makefile.
> - Fixed gen-version-script to be compliant with old "sh" implementation.

Ok -- tests on linux reveal...

Checking for strsep... No (will use our own instead).

and

Checking for standard version of asctime_r... No (will define
_POSIX_PTHREAD_SEMANTICS to get it).

testing...

$ gcc compat/have_strsep.c
compat/have_strsep.c: In function ‘main’:
compat/have_strsep.c:7:21: error: expected identifier or ‘(’ before ‘const’
compat/have_strsep.c:9:29: error: ‘delim’ undeclared (first use in this
function)
compat/have_strsep.c:9:29: note: each undeclared identifier is reported
only once for each function it appears in
zsh: exit 1     gcc compat/have_strsep.c


--- It is very easy to spot the problem ;)

$ gcc compat/check_asctime.c
compat/check_asctime.c: In function ‘main’:
compat/check_asctime.c:15:5: error: too many arguments to function
‘asctime_r’
In file included from compat/check_asctime.c:8:0:
/usr/include/time.h:266:14: note: declared here
zsh: exit 1     gcc compat/check_asctime.c

--- the posix-semantics way uses the 2-arg format. 

The logic of the test setting in this file doesn't open to
me. Why not test the same way as in getpwuid_r() case ?

Tomi