[PATCH 1/2] test: add check for <expected> filename argument for test_expect_equal_file

[Tomi Ollila]

On Fri, Oct 12 2012, Ethan Glasser-Camp wrote:

> Dmitry Kurochkin <dmitry.kurochkin at gmail.com> writes:
>
>> Actually, we can do both: check file name for consistent diff order
>> (from expected to actual) and use file names that the caller provides.
>
> Hi! Reviewing the patch queue a little bit here. It seems like this
> patch ended up getting dropped because the other approach (using the
> filenames that the caller provided) won out and was even pushed. I'm
> therefore marking this series notmuch::obsolete (and also
> notmuch::stale since it doesn't apply cleanly).

I think stale is unnecessary and inconvenient when patch is marked
obsolete

1) it is easier to look for stale patches by just searching stale tag
2) most obsolete patch goes stale at later time

If no-one resists I'll execute

notmuch tag -notmuch::stale tag:notmuch::obsolete

in near future (I take silence as an approval :D).

Currently:

notmuch search --output=messages tag:notmuch::stale and tag:notmuch::obsolete

id:1334077496-9172-3-git-send-email-markwalters1009 at gmail.com
id:1334077496-9172-2-git-send-email-markwalters1009 at gmail.com
id:1331402091-15663-1-git-send-email-tom.prince at ualberta.net
id:1328141050-30356-2-git-send-email-dmitry.kurochkin at gmail.com
id:1327985666-29191-3-git-send-email-dmitry.kurochkin at gmail.com
id:1327961195-4204-2-git-send-email-dmitry.kurochkin at gmail.com
id:1327926286-16680-2-git-send-email-dmitry.kurochkin at gmail.com
id:1325986015-22510-5-git-send-email-jrollins at finestructure.net


Tomi