[PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

Ethan Glasser-Camp ethan.glasser.camp at gmail.com
Mon Oct 15 20:12:51 PDT 2012


Mark Walters <markwalters1009 at gmail.com> writes:

> I like the use of separator rather than hard-wiring " or ". My personal
> preference would be to make that change but keep the two functions
> separate (my "C"ness makes me like functions that have clear return
> types!) But I am happy with the change too.

I agree with this comment. Especially in dynamic languages, it's a good
idea for each function to have only one return type.

Also, it seems that the commit message has a TAB character in it (",<TAB>-search").

Ethan


More information about the notmuch mailing list