[PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

Ethan Glasser-Camp ethan.glasser.camp at gmail.com
Mon Oct 15 19:59:27 PDT 2012


Mark Walters <markwalters1009 at gmail.com> writes:

> The original function feels a little fragile to me as to what happens if
> predicate or function move point. Eg what happens if function collapses
> the message: where does point go, and so where does
> notmuch-show-goto-message-next go. Is this just my naivete as a lisp
> beginner? Is there someway of writing it so the user doesn't need to
> worry about such things?

Although collapsing the message doesn't seem to move point, it would
probably be a good idea to wrap the calls to predicate and function in
save-excursion, as a guard against subtle and hard-to-spot bugs with
operations not being applied to all the right messages..

Ethan


More information about the notmuch mailing list