Release checks v3

Michal Nazarewicz mina86 at mina86.com
Tue Sep 4 08:41:46 PDT 2012


On Tue, Sep 04 2012, Tomi Ollila wrote:
> This if V3 of release-check.sh patches, displacing
>
> id:"1346491928-2356-1-git-send-email-tomi.ollila at iki.fi"
>
> Changes:
>
> Bash kept, mainly for pipefail -- and that possible future pipeline 
> additions have more protection.
>
> Added set -o posix lessens drifts to more bashishms -- and somewhere was 
> mentioned that posix mode provides a bit more robust pipefail...
>
> Changed that one short circuit & continues to if... elif... fi construct.
>
> Used  *[^0-9.]*) for matching non-digit and non-dot characters; this
> was really nice one.
>
> One formatting change (added newline).
>
> Removed last 'exit 0'.

Looks good to me.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn at google.com>--------------ooO--(_)--Ooo--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120904/17975933/attachment.pgp>


More information about the notmuch mailing list