[PATCH 0/3] Notmuch pick: a threaded view

Mark Walters markwalters1009 at gmail.com
Wed Jul 11 11:57:04 PDT 2012


Hello

Notmuch pick is an emacs view which displays a threaded view of
messages: each message has its own line and the thread structure is
shown with UTF-8 graphics characters (so it looks vaguely similar to
mutt's threaded view)

Pick was originally written by David Edmondon and posted on irc and I
have been developing it on and off since.  Now that almost all the
backend changes it uses are in I would like to see about getting it
into mainline.

However, the code is definitely not of the same standard as the main
notmuch code. One suggestion on irc was that we put it in contrib and
ship a stub notmuch-pick.el file in mainline so all a user would need
to do is replace the stub by the full version and compile.

This patch series implements this approach. I have managed to keep the
impact on the main notmuch code minimal: a stub pick file (which is
almost entirely the copyright boilerplate) and a entry from the main
notmuch.el. The way it works is that notmuch unconditionally calls
notmuch-pick-init when started: in the default case (the stub file)
this does nothing, whereas if the user replaces the stub by the full
file this sets up all the keybinding etc.

I have code for another approach which is only a little bigger: I add
a variable notmuch-pick-wanted and if the user sets this (which could
be by using setq in their .emacs file, or we could add a defcustom
option) which tells the code whether to load the pick functionality or
not.

In all the above cases this should give no change for a user who does
not enable the functionality. In the latter two cases notmuch-pick
would show up during compilation, whereas in the former it should be
completely invisible.

Any comments on the preferred approach?

Finally there have been suggestion that the name notmuch-pick is not
intuitive: are there any suggestions for a better name?

Best wishes

Mark

Mark Walters (3):
  emacs: add a stub notmuch-pick.el file
  emacs: add a stub entry to notmuch-pick in notmuch.el
  emacs: make notmuch-show return its buffer

 emacs/Makefile.local  |    3 ++-
 emacs/notmuch-pick.el |   28 ++++++++++++++++++++++++++++
 emacs/notmuch-show.el |    3 ++-
 emacs/notmuch.el      |    2 ++
 4 files changed, 34 insertions(+), 2 deletions(-)
 create mode 100644 emacs/notmuch-pick.el

-- 
1.7.9.1



More information about the notmuch mailing list