[PATCH 1/3] emacs: add no-display arg to notmuch-hello-refresh-hook

Austin Clements amdragon at MIT.EDU
Mon Jul 9 18:49:46 PDT 2012


Quoth Jani Nikula on Jun 15 at  6:53 pm:
> Add no-display arg to notmuch-hello-refresh-hook to allow each hook to
> decide what is appropriate when no-display is t, which is typically
> the case when called non-interactively. This is used by the following
> patch.
> 
> This breaks existing hooks people might have, which will now need to
> accept the argument.
> 
> Signed-off-by: Jani Nikula <jani at nikula.org>

This seems like an overloaded use of no-display.  If I'm reading the
code right, no-display indicates whether or not the notmuch-hello
buffer should be switched to and seems like a workaround for some
particular corner-case (I'm not even sure what).  This seems like a
strange condition to predicate a hook on (but maybe I just don't
understand).  What condition, abstractly speaking, is
notmuch-hello-refresh-status-message trying to run under?


More information about the notmuch mailing list