[PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters, and functions to support it

[Jameson Graef Rollins]

On Tue, May 22 2012, Jani Nikula <jani at nikula.org> wrote:
>> +/* for the specified protocol return the context pointer (initializing
>> + * if needed) */
>> +GMimeCryptoContext *
>> +notmuch_crypto_get_context (notmuch_crypto_t *crypto, const char
> *protocol)
>> +{
>> +    GMimeCryptoContext *cryptoctx = NULL;
>
> Isn't GMimeCryptoContext gmime 2.6 specific? It's #ifdeffed elsewhere at
> least. Also affects the return type.

Yes, good catch, Jani.  Thank you.  Will fix.

>> +    if ((strcmp (protocol, "application/pgp-signature") == 0)
>> +       || (strcmp (protocol, "application/pgp-encrypted") == 0)) {
>
> Is protocol guaranteed to be lower case?

That's a good question.  I don't know.  I'll check and fix
appropriately.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120523/8d6791ec/attachment.pgp>