[PATCH] go: Update to the current notmuch_database_find_message API

[Sebastien Binet]

Justus,

Justus Winter <4winter at informatik.uni-hamburg.de> writes:

> Quoting David Bremner (2012-04-30 13:53:47)
>> Austin Clements <amdragon at MIT.EDU> writes:
>> 
>> > The signature of notmuch_database_find_message was changed in 02a30767
>> > to report errors and the Go bindings were never updated.  This brings
>> > the Go bindings in sync with that change and at least makes them
>> > compile with Go r60.3, the last release before Go 1.
>> 
>> I don't have any easy way to test this, since the current versions in 
>> Debian are all based on Go 1.  On the other hand I guess it doesn't make
>> things worse.  Anybody have any objections to this patch?
>
> lgtm.
>
>> In the long run we have to decide what to do about these bindings. Seb
>> (or anyone else) are you interested in porting them to Go 1 and
>> maintaining them?  Otherwise it may be time to deprecate them.
>
> I care enough for the go environment to keep the go bindings
> working. I've updated the bindings, the build infrastructure and the
> notmuch-addrlookup utility to go 1. I'll send a patch series as a
> followup that is meant to be applied upon Austins patch.
>
> The last patch in the series is a cleanup of the source code done with
> the gofmt utility. Go is somewhat strict in its coding conventions,
> but there is a utility that magically formats code. This makes the go
> code in the wild remarkably consistent. We should stick to the
> conventions too, hence this patch even if it breaks git blame
> somewhat.
>
> I haven't tested the bindings in depth, but the notmuch-addrlookup
> utility seems to be working fine.

kudos for picking this up.
I must say I don't use these go bindings in anger anymore: this was
mainly a test project for go.
(I am still a happy go user as well as a notmuch one, though, but I
prefer bbdb to notmuch-addrlookup)

-s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120430/a6285059/attachment.pgp>