[PATCH v2 2/3] reply: add message-id header

Adam Wolfe Gordon awg+notmuch at xvx.ca
Wed Apr 18 10:27:50 PDT 2012

On Wed, Apr 18, 2012 at 07:09, Jani Nikula <jani at nikula.org> wrote:
> I do wonder whether the emacs ui / message mode will add a duplicate
> message-id rather than override this.

I think the emacs reply code will replace Message-ID and User-Agent
headers correctly, as it does with the From header when selecting a
different identity within emacs. But, this should be tested.

Ideally, the emacs tests should catch any problems here. As things are
right now, I think we would catch problems with the User-Agent header
in the reply tests: the tests replace the emacs and notmuch versions
with XXX but otherwise leave the header intact, so it should differ
from the one generated by notmuch compose.

The Message-ID is trickier, since in emacs it's generated when the
message is sent, not when the message is created, and thus the reply
tests don't see it at all. The "Sending a message via (fake) SMTP"
test could potentially catch problems, but currently the tests don't
try to predict the Message-ID emacs will give the message, so they
replace it with XXX.

-- Adam

More information about the notmuch mailing list