[PATCH] emacs-show: open excluded matches if no other matches

Tomi Ollila tomi.ollila at iki.fi
Thu Apr 12 12:20:52 PDT 2012


On Thu, Apr 12 2012, Jameson Graef Rollins wrote:

> On Thu, Mar 15 2012, Mark Walters <markwalters1009 at gmail.com> wrote:
>> Currently emacs show does not open matching but excluded
>> messages. This is normally the desired behaviour but is probably not
>> ideal if only excluded messages match. This patch opens all the
>> matching (necessarily excluded) messages in this case and goes to the
>> first one.
>
> Hi, Mark.  I have tested this patch and it LGTM.  I think this is the
> behavior we want, since it's no fun to open up a show buffer and have
> all messages in the thread closed.  That doesn't make much sense.

I disagree: If I open up a show buffer I'd like to have all messages
in the thread closed if search terms do not match. But that is my
opinion and inconsistent with current behaviour.

(Therefore I already +1:d this patch)

An example: I have thread of 100 messages and 1 of those is unread.
Search terms is tag:unread. I enter the thread: 99 messages closed
and this one open. Now unread is automatically removed. If I go back
to search view (by pressing q) and re-choose the same thread,
current behaviour is to open all 100 messages. I'd like to see all
100 messages closed.

> jamie.

Tomi


More information about the notmuch mailing list