[PATCH 2/4] dirent->d_type not available on Soalris

Adam Wolfe Gordon awg+notmuch at xvx.ca
Mon Apr 9 08:46:48 PDT 2012

On Mon, Apr 9, 2012 at 09:12, Vladimir Marek <Vladimir.Marek at oracle.com> wrote:
> Fair enough. Is there some performance test suite? Another way would be
> to make this compile time option set by configure. Used only when the
> system in question does not have dirent->d_type member.

I like the idea of making it configurable. From the Linux readdir(3) man page:

> Under glibc, programs can check  for  the  availability
> of  the  fields  not defined in POSIX.1 by testing whether
> the macros _DIRENT_HAVE_D_NAMLEN,
> or  _DIRENT_HAVE_D_TYPE  are defined.

I read this as meaning that we can just test for _DIRENT_HAVE_D_TYPE
instead of adding our own define.

I expect the stat system calls will provide some overhead, and there's
no real need to pay that overhead on systems where it isn't necessary.

-- Adam

More information about the notmuch mailing list