[PATCH 2/8] hex-escape: be more strict about the format while decoding

[Jani Nikula]

On Thu, 05 Apr 2012 08:33:23 -0300, David Bremner <david at tethera.net> wrote:
> Jani Nikula <jani at nikula.org> writes:
> 
> > Signed-off-by: Jani Nikula <jani at nikula.org>
> >
> > ---
> >
> > This could be folded to "hex-escape: (en|de)code strings to/from
> > restricted character set".
> 
> That's probably a good plan.
> 
> > -	    if (len < 3)
> > +	    if (!isxdigit ((unsigned char) p[1]) ||
> > +		!isxdigit ((unsigned char) p[2]))
> 
> What happens if there are not two characters after the escape? Is this
> relying on calling isxdigit on the null terminator?

It is, and technically there's nothing wrong with that. Would you prefer
explicit checks for '\0' in the if condition, for clarity? Or a comment
about it?

Jani.