[PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

Austin Clements amdragon at MIT.EDU
Wed Mar 28 19:08:31 PDT 2012


Quoth Jameson Graef Rollins on Mar 28 at  6:46 pm:
> On Mon, Mar 26 2012, Austin Clements <amdragon at MIT.EDU> wrote:
> > Previously, this function took an argument called "message-id", even
> > though it was a general query, rather than a message ID.  This changes
> > it to "query".
> 
> I'm sure the argument was named such because: the function is retrieving
> a message part so the query has to match just a single message, and it's
> only ever given a message id by anything that calls it.  And it's an
> unexposed internal function.  All of this to say that I think it doesn't
> really matter that the argument was named as it was.

All true.  But there's a difference between a message ID and an id:
query and the argument name threw me off for a moment when I was
writing the id: query quoting patch.  It could be `id-query', I
suppose, but really it could be any query that matches a single
message.


More information about the notmuch mailing list