[PATCH 0/2] Escape message ID queries in Emacs

Tomi Ollila tomi.ollila at iki.fi
Mon Mar 26 23:45:47 PDT 2012


On Tue, Mar 27 2012, Austin Clements wrote:

> Currently, Emacs does not escape message ID queries and is
> inconsistent about quoting them.  This patch centralizes this in one
> function that always produces a properly quoted and escaped message ID
> query.
>
> With this, Emacs no longer gets confused by Tomi's crazy message,
>   id:"id:""1332281811-24710-2b-git-send-email-tomi.ollila at iki.fi"""

LGTM. Things work!


One observation, though:

In search bar the following queries return one match:

id:id:"1332281811-24710-2b-git-send-email-tomi.ollila at iki.fi"
id:"id:""1332281811-24710-2b-git-send-email-tomi.ollila at iki.fi"""

but

id:"id:"1332281811-24710-2b-git-send-email-tomi.ollila at iki.fi""

return 0 matches.

It looks like the (above) search strings goes verbatim to command line

i.e. 'notmuch' 'search' '--sort=oldest-first' 'id:...'

can be used to compare... so that would be CLI issue if there
is ever need to do do anything with it.

+1

Thanks for fixing this.

Tomi


More information about the notmuch mailing list