[Patch v2 0/3] Add test and fix exclude bug

Jameson Graef Rollins jrollins at finestructure.net
Fri Mar 16 23:02:25 PDT 2012

On Wed, 14 Mar 2012 12:26:51 +0000, Mark Walters <markwalters1009 at gmail.com> wrote:
> The test in the previous patches
> id:"1331551914-28323-1-git-send-email-markwalters1009 at gmail.com"
> triggered the bug accidentally. It accidentally set the exclude tags
> to be "=" and "deleted" rather than just "deleted". The non-existent
> "=" tag (i.e., the tag that does not occur anywhere in the Xapian
> database) triggered the bug. First we correct the tests to just set
> the "deleted" tag, then we add some tests including one with a
> deliberately non-existent tag. Finally, we modify the exclusion code
> to avoid the bug.
> The modification also appears to fix a similar problem for jrollins
> that I have not yet been able to reproduce.
> Since the code is now more clearly correct, cleaner and we do
> definitely avoid a Xapian bug I think these patches can be committed
> even without knowing why it fixed jrollins' bug.
> Finally these apply to current master (not to the --with-excluded series).

tested, and it works for me, so LGTM.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120316/7bbe4392/attachment.pgp>

More information about the notmuch mailing list