[PATCH 0/5] Move --no-exclude to --exclude=(true|false|flag)

Mark Walters markwalters1009 at gmail.com
Thu Mar 15 11:42:00 PDT 2012


This series changes the --no-exclude options to count, search and show
to --exclude=(true|false|flag). It also changes the default to true
rather than flag for speed and for uncluttered command line output.

This series replaces the series
id:"1330779918-28024-1-git-send-email-markwalters1009 at gmail.com". Jani
suggested the --exclude= rather than --with-excluded approach as being
both clearer and easier to extend.

It is intend to apply on top of the bugfix series
id:"1331728014-32698-1-git-send-email-markwalters1009 at gmail.com".

There should be no significant logic change (i.e. the logic in the lib
is unchanged) but the defaults for the command lines are different.

The general idea is that when complete threads are requested then we
always return complete threads including any messages matching the
exclude tags (where appropriate these are flagged excluded), but we
may not return threads that only match in excluded messages.

The rationale is that it is awkward to deal with a thread with
"missing" messages.

Best wishes

Mark

Mark Walters (5):
  lib: change default for notmuch_query_set_omit_excluded
  cli: move count to the new --exclude=(true|false|flag) naming scheme.
  cli: move search to the new --exclude= naming scheme.
  cli: move show to the new --exclude= option naming scheme.
  emacs: make show set --exclude=flag

 emacs/notmuch-show.el     |    6 ++++--
 lib/notmuch.h             |   11 ++++++-----
 lib/query.cc              |   10 +++++-----
 man/man1/notmuch-count.1  |    5 +++--
 man/man1/notmuch-search.1 |   12 +++++++++---
 man/man1/notmuch-show.1   |   16 ++++++++++++++--
 notmuch-client.h          |    1 +
 notmuch-count.c           |   17 ++++++++++++-----
 notmuch-search.c          |   32 +++++++++++++++++++++++---------
 notmuch-show.c            |   39 +++++++++++++++++++++++++++++----------
 test/count                |    4 ++--
 test/search               |   13 ++++++-------
 12 files changed, 114 insertions(+), 52 deletions(-)

-- 
1.7.9.1



More information about the notmuch mailing list