[PATCH 0/3] argument parsing additions

Jani Nikula jani at nikula.org
Fri Mar 9 14:33:27 PST 2012


Hi Mark -

I'm not sure which is worse, criticizing or rewriting other people's
patches. I already did the former, and now I'm doing the
latter. Apologies for both. I didn't really mean to write these patches,
but it turned out to be more fun writing a proper reply in C than in
English.

Patch 1 adds --arg=true and --arg=false support for booleans. It's not
strictly required for the --entire-thread support in patch 3, which uses
the extension of keyword arguments from patch 2, but it's for
consistency across boolean arguments.

Please let me know what you think.

BR,
Jani.


Jani Nikula (3):
  command-line-arguments: allow true and false keywords for booleans
  command-line-arguments: support keyword arguments with default value
  cli: allow switching off entire thread mode in notmuch show json
    format

 command-line-arguments.c |   45 +++++++++++++++++++++++++++++++++++++++------
 command-line-arguments.h |    1 +
 notmuch-show.c           |   12 ++++++++++--
 3 files changed, 50 insertions(+), 8 deletions(-)

-- 
1.7.5.4



More information about the notmuch mailing list