[PATCH v2 3/8] show: Allow formatters to return errors

[Mark Walters]

On Tue,  6 Mar 2012 18:48:39 +0000, Austin Clements <amdragon at MIT.EDU> wrote:
> Formatter errors are propagated to the exit status of notmuch show.
> 
> This isn't used by the JSON or text formatters, but it will be useful
> for the raw format, which is pickier.

I am not very familiar with this part of the code but the whole series
looks fine to me.

My only minor comment is that I like Tom's suggestion (in
id:"m2399qrtat.fsf at guru.guru-group.fi") of having NOTMUCH_STATUS_FAILURE
(= 1) to make the error handling look cleaner. Alternatively (or
possibly as well) the functions do_show and do_show_messages could pass
the actual error back up to notmuch_show_command and then that function
could convert return 0/1 as appropriate.

As usual I am quite happy to be overruled!

Best wishes

Mark