[PATCH 0/5] Rewrite mbox and raw show formats

Tomi Ollila tomi.ollila at iki.fi
Sat Mar 3 00:18:50 PST 2012


On Sat,  3 Mar 2012 00:20:20 -0500, Austin Clements <amdragon at MIT.EDU> wrote:
> The show (rewrite) must go on.  These are the last two formats in
> notmuch show proper; the only remaining format is the reply format.
> 
> One of the ultimate goals of the show rewrite is to make raw actually
> work (and probably to split it into two different formats).  This
> series does not do that; it just ports the existing raw format.  I
> plan to make the new raw formats once the rewrite is done.

The whole patch series LGTM.

On somewhat related note: should there be NOTMUCH_STATUS_FAILURE (= 1)
in enum _notmuch_status (indicating unspecified failure). This would make
lines like
   return show_message (ctx, format, message, 0, params) != NOTMUCH_STATUS_SUCCESS;
look better (or were/are all of these failures due to memory exhaustion) ?

Tomi


More information about the notmuch mailing list