[PATCH] Update crypto test for gmime 2.6.5

Tomi Ollila tomi.ollila at iki.fi
Tue Feb 21 08:49:01 PST 2012


On Tue, 21 Feb 2012 17:05:43 +0100, Thomas Jost <schnouki at schnouki.net> wrote:
> gmime 2.6 had a bug [1] which made it impossible to tell why a signature
> verification failed when the signer key was unavailable (empty "sigstatus" field
> in the JSON output). Since 00b5623d the corresponding test is marked as broken
> when using gmime 2.6 (2.4 is fine).
> 
> The bug has been fixed in gmime 2.6.5. Consequently, the crypto test needs to be
> adjusted so that it is only marked broken for gmime 2.6.4 and below.
> 
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=668085
> ---
> 
> Hello world,
> 
> Here's a little update about gmime 2.6. The latest version (2.6.5)
> fixes the little regression introduced in 2.6.
> 
> In all honesty, I'm not sure adding such a workaround in the test
> suite is worth the effort. If gmime 2.6.5 is quickly packaged by major
> distros (it's already in Arch), we could as well make notmuch depend
> on gmime >= 2.6.5. (One line to change in configure). Or we could just
> stop trying to mark the test as broken and let it fail for buggy
> versions of gmime.
> 
> What do you think?

I'm in favor of gmime >= 2.6.5 requirement.

> 
> Best regards,
> Thomas

Tomi


More information about the notmuch mailing list