[PATCH v9 0/2] emacs: User-defined sections in notmuch-hello
Dmitry Kurochkin
dmitry.kurochkin at gmail.com
Thu Feb 16 23:48:01 PST 2012
Hi all.
I have finished reviewing the user-defined sections v8 series at last.
I found only few minor issues, some of which are fixed by this v9
series and others can be fixed later or ignored (e.g. renaming
notmuch-hello-insert-* functions to notmuch-hello-section-* or
something more appropriate). I believe it does not make to delay this
patches any more: they have been waiting long enough and each
review/rebase round is hard for both the author and reviewer because
the main patch is pretty big and not trivial. So I think we should
push this now. I am sure Daniel and I will fix all issues that we may
have missed :)
Changes in v9 since v8:
* correctly merge bc267b70b01c79f6bdda52641e9cd7574a151eff
* fix :hide-if-empty description:
s/and not hidden by show-if-empty/and not shown by show-empty-searches/
* fix typo in `notmuch-hello-target' docstring: s/globaly/global/
* add docstring for notmuch-hello-first-run
* fix indentation in `notmuch-hello-insert-saved-searches'
* fix indentation in `notmuch-hello-insert-searches' docstring
* fix target position calculation in `notmuch-hello-insert-saved-searches'
* s/User defined/User-defined/ in tests
* move tests to a new emacs-hello file
Regards,
Dmitry
More information about the notmuch
mailing list