[PATCH v2] emacs: Fix display of highlighted line in notmuch-search

[Dmitry Kurochkin]

On Thu, 16 Feb 2012 00:18:31 +0100, Michal Sojka <sojka at os.inf.tu-dresden.de> wrote:
> On Wed, 15 Feb 2012, Dmitry Kurochkin wrote:
> > Hi Michal.
> > 
> > On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka <sojka at os.inf.tu-dresden.de> wrote:
> > > When notmuch-search-line-faces is used to set background color in search
> > > results, the highlight of the current line is not always displayed
> > > correctly. This patch fixes that by increasing the priority property of
> > > the highlight overlay.
> > > ---
> > 
> > How about changing `notmuch-search-color-line' to use text properties
> > instead of overlays?  Then hl-line overlay would take priority over it
> > without these changes.
> > 
> > See [1] by David Edmondson on why text properties are better in
> > general.  I plan to use text properties here to simplify updating the
> > face when tags are changed.
> 
> Hmm, I always wondered why notmuch uses overlays even if Elisp manual
> says they don't scale. I remember that I wanted to replace that long
> time ago, but there was some problem, which I forgot. Maybe it was the
> invisibility David mentions. I guess there is some invisible text in
> search output, isn't it?
> 

Yes.  Also other faces (e.g. date, subject) are used in search.  If we
used properties in `notmuch-search-color-line', we would have to merge
with other properties.  So I take my proposal back.

Regards,
  Dmitry

> -Michal