[RFC PATCH v5 00/11] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

[Jameson Graef Rollins]

On Wed, 15 Feb 2012 09:03:28 +0000, Mark Walters <markwalters1009 at gmail.com> wrote:
> The current implementation of exclude-tags does not use excludes in
> notmuch-show.c (and thus not in notmuch-show.el). Thus when selecting 
> a thread in the search view claiming one matched message you may get 
> several matches in show all but one of which are tagged excluded.

Hey, Mark.  Thanks so much for working on this.  This is a very nice
extension to Austin's work.

> This set moves in a different direction. It returns all the results 
> but marks excluded messages with a new flag 
> (NOTMUCH_MESSAGE_FLAG_EXCLUDED) and lets the consumer decide what to 
> do with them. For example it could start with the message closed in 
> emacs show view, it could colour the headerline differently etc.

I missed some of the previous discussion on this, but rather than add a
new flag, why not just use the existing "match" flag?  If the message is
excluded, just mark "match" as "false".  I think this is basically all
we really want.  If the message is "excluded" include it in returned
threads, but just don't display it.  This is in fact exactly what the
"match" flag is currently for, and I can't see any reason not to use it
here.  We don't need to add anything new to the show output, and I
believe it will simplify this patch set considerably.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120215/5773a537/attachment-0001.pgp>