[PATCH v5 0/4] Reply enhancements (was: quoting HTML email ...)

Adam Wolfe Gordon awg+notmuch at xvx.ca
Tue Feb 14 21:00:23 PST 2012


Hi everyone,

There are relatively few changes from the last version [1], but the JSON
format has big changes again. A summary of all the changes:

* The JSON reply format now uses the new formatter from the show JSON
  format. This means that the MUA will not need to call notmuch show
  for text/* parts, except HTML, as the content of those parts will be
  included in the JSON output.

* The JSON reply format has changed in a few other minor ways, due to
  reusing the show code.

* Because the original message is now included in the reply format, the
  old show behavior of --format=json implies --entire-thread is reinstated.
  I still think this is a weird behavior, but there's no good reason to
  change it.

* The emacs code is simplified a bit by the changes to the JSON format, but
  its behavior is basically the same.

* Man pages and tests changed to reflect the above changes.

Note that, as implied above, this series relies on Austin's rewrite of the
show JSON formatter [2]. I should probably add the reply JSON format to
the devel/schemata file, but I'll leave that for another patch (perhaps
in a series with a news entry if this is deemed ready to push).

Thanks to everyone for the replies on previous versions, and please let
me know if you have any comments. Also, it would be great if others can
test this out on some interesting messages, as my email collection is
not very esoteric.

[1] id:"1328746916-25447-1-git-send-email-awg+notmuch at xvx.ca"
[2] id:"1329240823-7856-1-git-send-email-amdragon at mit.edu"

Adam Wolfe Gordon (4):
  test: Add broken test for the new JSON reply format.
  reply: Add a JSON reply format.
  man: Update notmuch-reply man page for JSON format.
  emacs: Use the new JSON reply format and message-cite-original

 emacs/notmuch-lib.el     |   39 +++++++++++
 emacs/notmuch-mua.el     |  123 +++++++++++++++++++++++++----------
 emacs/notmuch-show.el    |   24 +------
 man/man1/notmuch-reply.1 |    5 ++
 notmuch-client.h         |    3 +
 notmuch-reply.c          |  164 ++++++++++++++++++++++++++++++++++------------
 notmuch-show.c           |    2 +-
 test/emacs               |  101 ++++++++++++++++++++++++++++-
 test/multipart           |   51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 365 insertions(+), 103 deletions(-)

-- 
1.7.5.4



More information about the notmuch mailing list