Bug: emacs 23.2 doesn't like ido-completing-read

[Tomi Ollila]

On Sat, 04 Feb 2012 12:31:57 +0000, Mark Walters <markwalters1009 at gmail.com> wrote:
> 
> I hadn't realised before but this also goes wrong if you use the prefix
> argument to mail (eg ctrl-u m). The current code seems to mess up the
> mini-buffer and even closing the buffer does not get out of it.
> 
> Changing ido-completing-read read to completing-read seems to fix the
> problem entirely. Since this will affect most debian stable users (*) I
> think we should fix it. The trivial patch below works for me but other solutions
> may be better as they could maintain the benefits of ido-completing-read
> (eg that it shows the possibilities).
>
> Best wishes
> 
> Mark
> 
> (*) Perhaps only those who have more than one email address.
> 
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 023645e..41f82c2 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -191,7 +191,7 @@ the From: header is already filled in by notmuch."
>      ;; Now prompt the user, either for an email address only or for a full identity.
>      (if one-name-only
>  	(let ((address
> -	       (ido-completing-read (concat "Sender address for " name ": ") addresses
> +	       (completing-read (concat "Sender address for " name ": ") addresses
>  				    nil nil nil 'notmuch-mua-sender-history (car addresses))))
>  	  (concat name " <" address ">"))
>        (ido-completing-read "Send mail From: " notmuch-identities

Should that other ido-completing-read be kept there -- it is the only
one left after this patch...

Tomi


> -- 
> 1.7.2.3