[PATCH] test: replace occurrences of $PWD with vars that are more stable
Pieter Praet
pieter at praet.org
Fri Feb 3 02:20:58 PST 2012
On Thu, 02 Feb 2012 03:09:39 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> [...]
> I would prefer to put the whole second argument inside the quotes, not
> just the variable.
> [...]
>
I felt the same way initially, but then decided to leave the extra
quotes in place because the resulting fontification helps differentiate
between the vars and actual strings.
I assume that was the reason for the extra quotes' presence in the first
place? I might be wrong though...
So with that in mind, do I submit a new patch without the quotes, or leave
it as it is?
> Regards,
> Dmitry
>
> > mkdir -p "$(dirname "$external_msg_filename")"
> > mv "$gen_msg_filename" "$external_msg_filename"
> > ln -s "$external_msg_filename" "$gen_msg_filename"
> > --
> > 1.7.8.1
Peace
--
Pieter
More information about the notmuch
mailing list