[PATCH] test: make test_expect_equal_file() arguments flexible

[Tomi Ollila]

On Thu, 02 Feb 2012 14:33:56 +0000, David Edmondson <dme at dme.org> wrote:
> On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins <jrollins at finestructure.net> wrote:
> > If this is really a problem, I vote for 1.  In general, I am not in
> > favor of making the test suite more complicated than it needs to be.
> 
> After listening to the debate, I agree. The documentation should state
> that the order is 'expected actual' (or the other way around) and
> offenders should be shot on sight^W^W^Wfixed.

I've started to agree with Dmitry.

Why do something that computer can do -- to guide test writers to
give args in consistent order and provide suitable filenames.

Secondly as the output files are provided for human consumption
if there is consistent naming in expected output files helps 
developers getting parts of the big picture easier and finding 
right filenames easier.

... and the reviewers doesn't need to keep their plasma guns
handly.

Tomi