[PATCH] test: make test_expect_equal_file() arguments flexible

[Dmitry Kurochkin]

On Wed, 01 Feb 2012 10:55:50 +0200, Tomi Ollila <tomi.ollila at iki.fi> wrote:
> On Wed, 01 Feb 2012 00:47:30 -0800, Jameson Graef Rollins <jrollins at finestructure.net> wrote:
> > On Wed,  1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> > > The down side of this approach is that diff argument order depends on
> > > test_expect_equal_file() argument order.  So sometimes we get diff
> > > from expected to actual results, and sometimes the other way around.
> > > But the files are always named correctly.
> > 
> > Actually, I think this last point is the most important thing to retain.
> > Consistency in the diffs makes reading test results much more efficient.
> > The order I don't much care about.  But seeing as we have been
> > consistent with a particular order for a while, it seems like more
> > effort than it's worth to change it.
> 
> how about enforcing it in the test suite ?
> 
> case $file2 in 
> 	*.expected|*.EXPECTED) ;; 
>         *) echo "$file2" does not end with 'expected' >&2; exit 1
> esac
> 

It would break some existing tests.  But I like it.

Regards,
  Dmitry

> > 
> > jamie.
> 
> Tomi