[PATCH] test: make test_expect_equal_file() arguments flexible

Jameson Graef Rollins jrollins at finestructure.net
Wed Feb 1 00:47:30 PST 2012


On Wed,  1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> The down side of this approach is that diff argument order depends on
> test_expect_equal_file() argument order.  So sometimes we get diff
> from expected to actual results, and sometimes the other way around.
> But the files are always named correctly.

Actually, I think this last point is the most important thing to retain.
Consistency in the diffs makes reading test results much more efficient.
The order I don't much care about.  But seeing as we have been
consistent with a particular order for a while, it seems like more
effort than it's worth to change it.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120201/9a7940ed/attachment.pgp>


More information about the notmuch mailing list