[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

David Edmondson dme at dme.org
Mon Jan 30 01:23:40 PST 2012


On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner <david at tethera.net> wrote:
> On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani at nikula.org> wrote:
> > On Jan 28, 2012 2:41 PM, "David Bremner" <david at tethera.net> wrote:
> > 
> > Sometimes someone (Dmitry?) sent patches that separated a small functional
> > change, and the big non-functional indentation change it caused,
> > separately. Would you prefer (or tolerate ;) that style?
> 
> Hmm, that might be nicer, I'm not 100% sure.
> 
> I wouldn't say it's mandatory for a patch like this (and I'd say other
> peoples views on what's easy to review are at least as important as mine
> here).

Each patch should be valid in the repository without any following
patches (preceding are obviously okay). Incorrect indentation would
disqualify a patch from being 'valid', so it shouldn't be accepted.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/272614fb/attachment.pgp>


More information about the notmuch mailing list