[PATCH 4/6] test: fix emacs tests after tagging operations changes

Dmitry Kurochkin dmitry.kurochkin at gmail.com
Sun Jan 29 15:09:38 PST 2012


On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements <amdragon at MIT.EDU> wrote:
> Quoth Dmitry Kurochkin on Jan 28 at  8:41 am:
> > After the recent tagging operations changes, functions bound to "+"
> > and "-" in notmuch-search and notmuch-show views always read input
> > from the minibuffer.  Use kbd macros instead of calling them directly.
> 
> Should this be folded into the previous patch so these tests aren't
> temporarily broken?

I think it is a common approach for notmuch.  IIRC I sent patches which
changes both code and tests, and I was asked to move the tests to a
separate patch.  So I will leave it as is for now.  Though if you point
me to a relevant discussion or policy, which says that the tests should
be merged, I would be happy to do it.

Regards,
  Dmitry


More information about the notmuch mailing list