[PATCH 3/4 v2] test: Add test for Original Message hiding at point-min.

David Edmondson dme at dme.org
Wed Jan 25 23:22:07 PST 2012


I've applied changes in accordance with all of the feedback in this mail
and the others, except for...

On Wed, 25 Jan 2012 21:53:08 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> > +  (let ((notmuch-show-insert-text/plain-hook '(notmuch-wash-excerpt-citations))
> 
> Do we have to override the default value here?  I thought
> notmuch-wash-excerpt-citations was enabled by default.

It avoids potential confusion over where the problem lies.

> [...]
> 
> IMO writing the test in lisp does not give any benefit in this case.
> Quite the opposite: a simple test is split in two files and becomes more
> complex.
> 
> But since we accepted this way of writing tests and you seem to prefer
> it, I would not argue about changing it.

You're right - it's simpler in the original style here, so v3 switches
to that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120126/105cee90/attachment.pgp>


More information about the notmuch mailing list