[PATCH 1/4 v2] test: `visible-buffer-substring' should not return text properties.
Dmitry Kurochkin
dmitry.kurochkin at gmail.com
Wed Jan 25 09:35:07 PST 2012
On Wed, 25 Jan 2012 15:45:25 +0000, David Edmondson <dme at dme.org> wrote:
> When using `visible-buffer-substring' to examine a buffer, the text
> properties are not useful, so don't include them.
> ---
> test/test-lib.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/test/test-lib.el b/test/test-lib.el
> index bc75f06..36e793a 100644
> --- a/test/test-lib.el
> +++ b/test/test-lib.el
> @@ -60,7 +60,7 @@ FILENAME is OUTPUT."
> (while (< start end)
> (let ((next-pos (next-char-property-change start end)))
> (when (not (invisible-p start))
> - (setq str (concat str (buffer-substring start next-pos))))
> + (setq str (concat str (buffer-substring-no-properties start next-pos))))
I would wrap this line. But would not insist :)
Please update `visible-buffer-substring' and `visible-buffer-string'
docstring accordingly. Smth like:
"Same as `buffer-substring-no-properties', but excludes invisible
text."
"Same as `buffer-string', but excludes invisible text and text
properties."
Regards,
Dmitry
> (setq start next-pos)))
> str))
>
> --
> 1.7.8.3
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
More information about the notmuch
mailing list