[PATCH v3 2/2] search: Support automatic tag exclusions

Pieter Praet pieter at praet.org
Thu Jan 19 14:44:36 PST 2012


On Thu, 19 Jan 2012 22:01:27 +0000, Mark Walters <markwalters1009 at gmail.com> wrote:
> 
> > > I am happy with them appearing as a non matching message, but currently
> > > they appear as a full open message. (The patch to achieve this is
> > > trivial: essentially transpose part of Austin's patch of
> > > notmuch-search.c into notmuch-show.c)
> > 
> > This definitely sounds like the right thing to do.  We can argue about
> > more sophisticated UIs, but it should do this at a minimum.
> 
> I will post the trivial patch in a moment (trivial but I could easily
> have done something stupid).
> 
> I haven't written a test yet: should it have one, [...]

That would be preferrable, yes.

> [...] and if so, could
> someone point me to the appropriate place to put it?
> 

In "test/emacs", right after "Hiding message with visible citation in
notmuch-show view" would be perfect IMO.

As you can see, that test uses `test-visible-output', which should
provide the functionality you need.

> Best wishes
> 
> Mark


Thanks!


Peace

-- 
Pieter


More information about the notmuch mailing list