[PATCH 1/4] search: rename auto_exclude_tags to {search,}exclude_tags
Austin Clements
amdragon at MIT.EDU
Thu Jan 19 11:41:15 PST 2012
Quoth Pieter Praet on Jan 19 at 8:19 pm:
> All other config-related functions and args include the section
> title in their name, so for the sake of consistency, mirror that.
>
> Also, the "auto"matic part is a given, so that was dropped.
LGTM other than one nit, below.
> --- a/notmuch-config.c
> +++ b/notmuch-config.c
> @@ -89,9 +89,9 @@ static const char search_config_comment[] =
> "\n"
> " The following option is supported here:\n"
> "\n"
> - "\tauto_exclude_tags A ;-separated list of tags that will be\n"
> - "\t excluded from search results by default. Using an excluded tag\n"
> - "\t in a query will override that exclusion.\n";
> + "\texclude_tags A list (separated by ';') of the tags that will be\n"
> + "\t\texcluded from search results by default. Using an excluded tag in a\n"
> + "\t\tquery will override that exclusion.\n";
I'd propose that any tag whose name is more than seven characters long
should have its description start under it, indented by a tab, like I
did in id:"1326920205-31296-1-git-send-email-amdragon at mit.edu". That
looks nice and keeps the description indented consistently without
ridiculous amounts of negative space and narrow wrapping.
More information about the notmuch
mailing list