[PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

Dmitry Kurochkin dmitry.kurochkin at gmail.com
Tue Jan 17 06:51:58 PST 2012


On Tue, 17 Jan 2012 14:37:52 +0000, David Edmondson <dme at dme.org> wrote:
> (And for the list...)
> 
> On Tue, 17 Jan 2012 18:20:04 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> > Can you please elaborate why this is needed?
> 
> This code:
> 
> 		    # wait until the emacs server is up
> 		    until test_emacs '()' 2>/dev/null; do
> 			    sleep 1
> 		    done
> 
> outputs 'nil', so the first caller to test_emacs has 'nil\n' prepended
> to their expected output.

Thanks.  Would be nice to have this explained in the commit message.  No
need to resend just because of this though.

Regards,
  Dmitry


More information about the notmuch mailing list