[PATCH 2/2] notmuch-reply.c: uncrustify
Tomi Ollila
tomi.ollila at iki.fi
Thu Jan 12 05:46:36 PST 2012
On Thu, 12 Jan 2012 09:08:18 -0400, David Bremner <david at tethera.net> wrote:
>
> > All of the other format fixes look very reasonable to me. I think you
> > managed to find one of the least canonical source files in the tree.
> > Was that intentional?
>
> Yes, I expect there would be less changes elsewhere. Although the
> changes might be more controversial, I guess.
>
> The corresponding diff for notmuch-search.c follows
>
> diff --git a/notmuch-search.c b/notmuch-search.c
[ ... ]
> @@ -122,7 +122,7 @@ sanitize_string (const void *ctx, const char *str)
> loop = out = talloc_strdup (ctx, str);
>
> for (; *loop; loop++) {
> - if ((unsigned char)(*loop) < 32)
> + if ((unsigned char) (*loop) < 32)
> *loop = '?';
Should (cast) be concatenated without space to the castee
> }
> return out;
> @@ -160,7 +160,7 @@ format_item_id_json (const void *ctx,
> printf ("%s", json_quote_str (ctx_quote, item_id));
>
> talloc_free (ctx_quote);
> -
> +
Whee, whitespace-cleanup !
> }
>
[ ... ]
Tomi
More information about the notmuch
mailing list