[PATCH 0/4] Quoting HTML-only emails in replies redux

Adam Wolfe Gordon awg+notmuch at xvx.ca
Sat Jan 7 23:52:38 PST 2012


From: Adam Wolfe Gordon <awg at xvx.ca>

Hi everyone,

This is a rework of my previous patch series adding support for replying to HTML
email in the emacs interface
(id:1322671241-23438-1-git-send-email-awg+notmuch at xvx.ca).

It was suggested on IRC that a more general solution would be to add a JSON
format to notmuch reply, and then have the emacs client parse the JSON to create
an appropriate reply. This patchset implements that.

The previous patches had an issue with emails that contained both HTML and
plaintext parts, where all the parts would end up quoted. This version avoids
that problem, since the emacs interface can easily check whether there are
plaintext parts and avoid quoting HTML parts if there are.

There should probably be some customize variables for this in emacs, to control
(for example) whether to quote HTML parts and whether to prefer HTML or
plaintext parts for quoting. Any suggestions for what should be customizable
would be appreciated.

I know Jani is currently working on some reply-related patches (the reply-all
vs. reply-one set). These changes probably won't merge cleanly with those
changes, so some care might be required. If his changes are pushed first, I'll
happily rebase and send a new set.

Thanks in advance for any reviews.

Adam Wolfe Gordon (4):
  test: Add broken test for the new JSON reply format.
  reply: Add a JSON reply format.
  man: Update notmuch-reply man page for JSON format.
  emacs: Use the new JSON reply format.

 emacs/notmuch-mua.el     |   62 +++++++++---
 man/man1/notmuch-reply.1 |    5 +
 notmuch-reply.c          |  269 +++++++++++++++++++++++++++++++++++++++-------
 test/emacs               |    1 +
 test/multipart           |    7 ++
 5 files changed, 292 insertions(+), 52 deletions(-)

-- 
1.7.5.4



More information about the notmuch mailing list