[PATCH 2/2] python: make the result of Message.get_replies() more pythonic

Sebastian Spaeth Sebastian at SSpaeth.de
Mon Jan 2 08:03:51 PST 2012


On Wed, 21 Dec 2011 14:15:02 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote:
> Formerly Message.get_replies() returned an iterator or None forcing
> users to check the result before iterating over it leading to strange
> looking code at the call site.
> 
> Fix this flaw by adding an EmptyMessagesResult class that behaves like
> the Messages class but immediatly raises StopIteration if used as an
> iterator and returning objects of this type from Message.get_replies()
> to indicate that there are no replies.


Makes sense, pushed. It shouldn't cause the breaking of existing
clients... (famous last words)

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120102/4f019e40/attachment.pgp>


More information about the notmuch mailing list