[PATCH v2] Ignore encrypted parts when indexing.
Austin Clements
amdragon at MIT.EDU
Wed Dec 28 12:36:15 PST 2011
LGTM.
Quoth Jameson Graef Rollins on Dec 28 at 12:14 pm:
> It appears to be an oversight that encrypted parts were indexed
> previously. The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database. It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.
> ---
> Fixes missing colon. Thanks Austin, Xavier.
>
> lib/index.cc | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/lib/index.cc b/lib/index.cc
> index e8e9922..d8f8b2b 100644
> --- a/lib/index.cc
> +++ b/lib/index.cc
> @@ -339,6 +339,10 @@ _index_mime_part (notmuch_message_t *message,
> if (i > 1)
> fprintf (stderr, "Warning: Unexpected extra parts of multipart/signed. Indexing anyway.\n");
> }
> + if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
> + /* Don't index encrypted parts. */
> + continue;
> + }
> _index_mime_part (message,
> g_mime_multipart_get_part (multipart, i));
> }
More information about the notmuch
mailing list